Home >  Krazy Code Checker >  kde-4.x >  kdeutils >  kcalc

krazy2 Analysis

Checkers Run = 49
Files Processed = 31
Total Issues = 5 ...as of March 16 2010 04:14:25 CET

• For File Type c++
  1. Check for TRUE and FALSE macros [captruefalse]...okay!
  2. Check for methods that return 'const' refs in public classes [constref]...okay!
  3. Check for an acceptable copyright [copyright]...OOPS! 1 issues found!
     • kcalc_core.cpp: missing tags

     All source files must contain a copyright header which identifies the copyright holder(s) together with a e-mail address that can be used to reach the copyright holder. One copyright holder per line, with real email addresses please. For details regarding KDE's licensing policy please visit http://techbase.kde.org/Policies/Licensing_Policy. A typical copyright looks like: "Copyright 2002,2005-2006 Joe Hacker "

  4. Check for cpp macros and usage [cpp]...okay!
  5. Check for code that should be considered crashy. [crashy]...okay!
  6. Check single-char QString operations for efficiency [doublequote_chars]...OOPS! 2 issues found!
     • kcalcdisplay.cpp: line# 202,370 (2)

     Adding single characters to a QString is faster if the characters are QChars and not QStrings. For example: QString path = oldpath + "/" + base is better written as QString path = oldpath + '/' + base. Same holds for arguments to QString::startsWith(), QString::endsWith(), QString::remove(), QString::section(), and QString::split(). Use QString::remove() instead of QString::replace(foo,"")

  7. Check public classes with private members or d-pointer issues [dpointer]...okay!
  8. Check for QString compares to "" [emptystrcompare]...okay!
  9. Check that file ends with a newline [endswithnewline]...okay!
  10. Check for C++ ctors that should be declared 'explicit' [explicit]...okay!
  11. Check for foreach loop issues [foreach]...okay!
  12. Check validity of i18n calls [i18ncheckarg]...okay!
  13. Check for invalid icon names [iconnames]...okay!
  14. Check for proper include directives [includes]...OOPS! 1 issues found!
      • kcalc.h: put config.h in angle brackets line# 50 (1)

      Use <..> to include installed headers; to include Qt headers from installed headers; cpp file should include their own headers first (but below config.h); other rules apply, see http://techbase.kde.org/Policies/Library_Code_Policy#Getting_.23includes_right. Use include guards in headers with appropriatedly encoded macro names.

  15. Check for inline methods in public classes [inline]...okay!
  16. Check for an acceptable license [license]...okay!
  17. Check for assignments to QString::null [nullstrassign]...okay!
  18. Check for compares to QString::null or QString() [nullstrcompare]...okay!
  19. Check for C++ operators that should be 'const' [operators]...okay!
  20. Check for inappropriate pass-by-value function args [passbyvalue]...okay!
  21. Check for postfix usage of ++ and -- [postfixop]...okay!
  22. Check for dangerous or inefficient QByteArray usage [qbytearray]...okay!
  23. Check for Qt classes that should not be used [qclasses]...okay!
  24. Check for Qt methods that should be avoided [qmethods]...okay!
  25. Check for QMIN and QMAX macros [qminmax]...okay!
  26. Check for classes that should use the 'Q_OBJECT' macro [qobject]...okay!
  27. Check for signals: and slots: [sigsandslots]...okay!
  28. Check for spelling errors [spelling]...okay!
  29. Check for strings used improperly or should be i18n. [strings]...okay!
  30. Check for system calls to replace by KDE or Qt equivalents [syscalls]...okay!
  31. Check for typedefs that should be replaced by Qt typedefs [typedefs]...okay!
• For File Type kconfigxt
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check validity of i18n calls [i18ncheckarg]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates KConfigXT files using 'xmllint' [validate]...okay!
• For File Type designer
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for files that need to be fixed by 'fixuifiles' [fixuifiles]...okay!
  3. Check validity of i18n calls [i18ncheckarg]...okay!
  4. Check for Qt classes that should not be used [qclasses]...OOPS! 1 issues found!
     • constants.ui: QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit],QLineEdit[KLineEdit]

     Don't use Qt 4 classes that are deprecated. Additionally make sure to use the KDE version of some Qt GUI elements to provide a consistent look and feel for the KDE desktop. The KDE classes are not just adding functionalities to the Qt base class and are mostly not even based on the Qt class. http://techbase.kde.org/Policies/API_to_Avoid Please refer to the API documentation for details before porting to the K classes.

  5. Check for spelling errors [spelling]...okay!
• For File Type kpartgui
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check validity of i18n calls [i18ncheckarg]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates kpartgui files using 'xmllint' [validate]...okay!
• For File Type messages
  1. Check for appending to rc.cpp [rcappend]...okay!
• For File Type desktop
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for invalid icon names [iconnames]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates desktop files using 'desktop-file-validate' [validate]...okay!