Home >  Krazy Code Checker >  kde-4.x >  kdeutils >  kgpg

krazy2 Analysis

Checkers Run = 52
Files Processed = 185
Total Issues = 3 ...as of September 03 2010 01:32:39 CEST

• For File Type c++
  1. Check for TRUE and FALSE macros [captruefalse]...okay!
  2. Check for methods that return 'const' refs in public classes [constref]...okay!
  3. Check for an acceptable copyright [copyright]...okay!
  4. Check for cpp macros and usage [cpp]...okay!
  5. Check for code that should be considered crashy. [crashy]...okay!
  6. Check single-char QString operations for efficiency [doublequote_chars]...okay!
  7. Check for unwanted doxygen tags in major versions [doxytags]...okay!
  8. Check public classes with private members or d-pointer issues [dpointer]...okay!
  9. Check for QString compares to "" [emptystrcompare]...okay!
  10. Check that file ends with a newline [endswithnewline]...okay!
  11. Check for C++ ctors that should be declared 'explicit' [explicit]...okay!
  12. Check for foreach loop issues [foreach]...okay!
  13. Check validity of i18n calls [i18ncheckarg]...okay!
  14. Check for invalid icon names [iconnames]...okay!
  15. Check for proper include directives [includes]...okay!
  16. Check for inline methods in public classes [inline]...okay!
  17. Check for an acceptable license [license]...okay!
  18. Check for assignments to QString::null [nullstrassign]...okay!
  19. Check for compares to QString::null or QString() [nullstrcompare]...okay!
  20. Check for C++ operators that should be 'const' [operators]...okay!
  21. Check for inappropriate pass-by-value function args [passbyvalue]...okay!
  22. Check for postfix usage of ++ and -- [postfixop]...OOPS! 3 issues found!
      • kgpginterface.cpp: line# 684,692 (2)
      • transactions/kgpgimport.cpp: line# 197 (1)

      You should use ++ and -- as prefix whenever possible as these are more efficient than postfix operators. Prefix increments first and then uses the variable, postfix uses the actual; the variable is incremented as well. Because of this, the prefix operators are inherently more efficient. WARNING Make sure that you don't introduce off-by-one errors when changing i++ to ++i.

  23. Check for dangerous or inefficient QByteArray usage [qbytearray]...okay!
  24. Check for Qt classes that should not be used [qclasses]...okay!
  25. Check for Qt methods that should be avoided [qmethods]...okay!
  26. Check for QMIN and QMAX macros [qminmax]...okay!
  27. Check for classes that should use the 'Q_OBJECT' macro [qobject]...okay!
  28. Check for signals: and slots: [sigsandslots]...okay!
  29. Check for spelling errors [spelling]...okay!
  30. Check for strings used improperly or should be i18n. [strings]...okay!
  31. Check for system calls to replace by KDE or Qt equivalents [syscalls]...okay!
  32. Check for typedefs that should be replaced by Qt typedefs [typedefs]...okay!
• For File Type desktop
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for invalid icon names [iconnames]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates desktop files using 'desktop-file-validate' [validate]...okay!
• For File Type designer
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for files that need to be fixed by 'fixuifiles' [fixuifiles]...okay!
  3. Check validity of i18n calls [i18ncheckarg]...okay!
  4. Check for Qt classes that should not be used [qclasses]...okay!
  5. Check for spelling errors [spelling]...okay!
• For File Type tips
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for spelling errors [spelling]...okay!
• For File Type kpartgui
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check validity of i18n calls [i18ncheckarg]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates kpartgui files using 'xmllint' [validate]...okay!
• For File Type messages
  1. Check for appending to rc.cpp [rcappend]...okay!
• For File Type kconfigxt
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check validity of i18n calls [i18ncheckarg]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates KConfigXT files using 'xmllint' [validate]...okay!