Home >  Krazy Code Checker >  kde-4.x >  kdeutils >  okteta

krazy2 Analysis

Checkers Run = 50
Files Processed = 1097
Total Issues = 14 ...as of September 03 2010 03:05:21 CEST

• For File Type c++
  1. Check for TRUE and FALSE macros [captruefalse]...okay!
  2. Check for methods that return 'const' refs in public classes [constref]...okay!
  3. Check for an acceptable copyright [copyright]...okay!
  4. Check for cpp macros and usage [cpp]...OOPS! 3 issues found!
     • gui/offsetformat.cpp: O/S or Compiler specific macro line# 28[[__GNUC__]] (1)
     • gui/kcursor.cpp: O/S or Compiler specific macro line# 25[[__GNUC__]] (1)
     • kasten/controllers/view/structures/structview.cpp: Guard #warning with '#ifdef __GNUC__' line# 275 (1)

     C++ source files and non-installed headers should NOT use cpp conditionals that check for a certain O/S or compiler; instead use CMake HAVE_foo macros. We want to check for features discovered during CMake time rather than for a specific O/S.

  5. Check for code that should be considered crashy. [crashy]...OOPS! 5 issues found!
     • libs/kasten/controllers/io/insert/insertcontroller.cpp: line# 130 (1)
     • libs/kasten/controllers/io/copyas/copyascontroller.cpp: line# 133 (1)
     • libs/kasten/controllers/io/export/exportcontroller.cpp: line# 127 (1)
     • libs/kasten/controllers/documentsystem/creator/creatorcontroller.cpp: line# 143 (1)
     • libs/kasten/core/system/modelcodecmanager.cpp: line# 135 (1)

     Looks for not using QPointers when showing modal dialogs via exec(), as discussed in http://www.kdedevelopers.org/node/3919

  6. Check single-char QString operations for efficiency [doublequote_chars]...OOPS! 1 issues found!
     • kasten/controllers/view/structures/structview.cpp: line# 278 (1)

     Adding single characters to a QString is faster if the characters are QChars and not QStrings. For example: QString path = oldpath + "/" + base is better written as QString path = oldpath + '/' + base. Same holds for arguments to QString::startsWith(), QString::endsWith(), QString::remove(), QString::section(), and QString::split(). Use QString::remove() instead of QString::replace(foo,"")

  7. Check for unwanted doxygen tags in major versions [doxytags]...okay!
  8. Check public classes with private members or d-pointer issues [dpointer]...okay!
  9. Check for QString compares to "" [emptystrcompare]...okay!
  10. Check that file ends with a newline [endswithnewline]...okay!
  11. Check for C++ ctors that should be declared 'explicit' [explicit]...okay!
  12. Check for foreach loop issues [foreach]...okay!
  13. Check validity of i18n calls [i18ncheckarg]...okay!
  14. Check for invalid icon names [iconnames]...okay!
  15. Check for proper include directives [includes]...OOPS! 1 issues found!
      • kasten/controllers/view/structures/modeltest.cpp: include own header first line# 26 (1)

      Use <..> to include installed headers; to include Qt headers from installed headers; cpp file should include their own headers first (but below config.h); other rules apply, see http://techbase.kde.org/Policies/Library_Code_Policy#Getting_.23includes_right. Use include guards in headers with appropriatedly encoded macro names.

  16. Check for inline methods in public classes [inline]...okay!
  17. Check for an acceptable license [license]...OOPS! 2 issues found!
      • kasten/controllers/view/structures/modeltest.h: GPL v3+ or v2-only is not compatible with Qt or KDE licensing
      • kasten/controllers/view/structures/modeltest.cpp: GPL v3+ or v2-only is not compatible with Qt or KDE licensing

      Each source file must contain a license or a reference to a license which states under which terms the software may be used, modified and redistributed. For details regarding KDE's licensing policy please visit http://techbase.kde.org/Policies/Licensing_Policy.

  18. Check for assignments to QString::null [nullstrassign]...okay!
  19. Check for compares to QString::null or QString() [nullstrcompare]...okay!
  20. Check for C++ operators that should be 'const' [operators]...okay!
  21. Check for inappropriate pass-by-value function args [passbyvalue]...okay!
  22. Check for postfix usage of ++ and -- [postfixop]...okay!
  23. Check for dangerous or inefficient QByteArray usage [qbytearray]...okay!
  24. Check for Qt classes that should not be used [qclasses]...okay!
  25. Check for Qt methods that should be avoided [qmethods]...okay!
  26. Check for QMIN and QMAX macros [qminmax]...okay!
  27. Check for classes that should use the 'Q_OBJECT' macro [qobject]...okay!
  28. Check for signals: and slots: [sigsandslots]...okay!
  29. Check for spelling errors [spelling]...OOPS! 1 issues found!
      • kasten/controllers/view/structures/datatypes/abstractarraydatainformation.cpp: line# 143[[optimise]] (1)

      Spelling errors in comments and strings should be fixed as they may show up later in API documentation, handbooks, etc. Misspelled strings make the translator's job harder. Please use US English.

  30. Check for strings used improperly or should be i18n. [strings]...okay!
  31. Check for system calls to replace by KDE or Qt equivalents [syscalls]...OOPS! 1 issues found!
      • kasten/controllers/document/info/bytearraymodeliodevice.cpp: line# 37[open[KDE_open]] (1)

      Some system calls are not portable, please use the suggested portable wrapper instead. See kde_file.h

  32. Check for typedefs that should be replaced by Qt typedefs [typedefs]...okay!
• For File Type kpartgui
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check validity of i18n calls [i18ncheckarg]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates kpartgui files using 'xmllint' [validate]...okay!
• For File Type messages
  1. Check for appending to rc.cpp [rcappend]...okay!
• For File Type desktop
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for invalid icon names [iconnames]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates desktop files using 'desktop-file-validate' [validate]...okay!
• For File Type designer
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for files that need to be fixed by 'fixuifiles' [fixuifiles]...okay!
  3. Check validity of i18n calls [i18ncheckarg]...okay!
  4. Check for Qt classes that should not be used [qclasses]...okay!
  5. Check for spelling errors [spelling]...okay!
• For File Type kconfigxt
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check validity of i18n calls [i18ncheckarg]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates KConfigXT files using 'xmllint' [validate]...okay!