Home > Krazy Code Checker > KDESUPPORT > kdesupport > eigen
Other kdesupport/eigen reports: [APIDOX] [Docs]
Results for kdesupport/kdesupport/eigen
Checkers Run = 26
Files Processed = 16
Total Issues = 20 ...as of July 05 2008 06:08:12 (SVN revision 828235)
- For File Type c++
- Check for TRUE and FALSE macros... okay!
- Check for methods that return 'const' refs in public classes... okay!
- Check for contractions in strings... okay!
- Check for an acceptable copyright... okay!
- Check for cpp macros and usage...
OOPS! 2 issues found!
- src/util.h: O/S or Compiler specific macro line#39[__GNUC__],40[__GNUC__>=4] (2)
C++ source files and non-installed headers should NOT use cpp conditionals that check for a certain O/S or compiler; instead use CMake HAVE_foo macros. We want to check for features discovered during CMake time rather than for a specific O/S.
- Check single-char QString operations for efficiency... okay!
- Check public classes with private members or d-pointer issues... okay!
- Check for QString compares to ""... okay!
- Check that file ends with a newline... okay!
- Check for C++ ctors that should be declared 'explicit'... okay!
- Check validity of i18n calls... okay!
- Check for invalid icon names... okay!
- Check for proper include directives...
OOPS! 2 issues found!
- src/projective.h: missing or improper include guard in header
- examples/qt/camera.cpp: include own header first line#29
Use <..> to include installed headers; <QtModule/QClass> to include Qt headers from installed headers; cpp file should include their own headers first; other rules apply, see http://techbase.kde.org/Policies/Library_Code_Policy#Getting_.23in cludes_right. Use include guards in headers with appropriatedly encoded macro names.
- Check for inline methods in public classes... okay!
- Check for an acceptable license...
OOPS! 16 issues found!
- src/projective.h: unacceptable license (GPL (v2+)) for library code
- src/ludecomposition.h: unacceptable license (GPL (v2+)) for library code
- src/regressioninternal.h: unacceptable license (GPL (v2+)) for library code
- src/util.h: unacceptable license (GPL (v2+)) for library code
- src/vectorbase.h: unacceptable license (GPL (v2+)) for library code
- src/matrixbase.h: unacceptable license (GPL (v2+)) for library code
- src/linearsolverbase.h: unacceptable license (GPL (v2+)) for library code
- src/regression.h: unacceptable license (GPL (v2+)) for library code
- src/vector.h: unacceptable license (GPL (v2+)) for library code
- src/matrix.h: unacceptable license (GPL (v2+)) for library code
- src/linearsolver.h: unacceptable license (GPL (v2+)) for library code
- src/ludecompositionbase.h: unacceptable license (GPL (v2+)) for library code
- src/disabled/quaternion.cpp: missing license
- src/disabled/quaternion.h: unacceptable license (GPL (v2+)) for library code
- examples/qt/camera.cpp: unacceptable license (GPL (v2+)) for library code
- examples/qt/camera.h: unacceptable license (GPL (v2+)) for library code
Each source file must contain a license or a reference to a license which states under which terms the software may be used, modified and redistributed. For details regarding KDE's licensing policy please visit http://techbase.kde.org/Policies/Licensing_Policy.
- Check for assignments to QString::null... okay!
- Check for compares to QString::null... okay!
- Check for inappropriate pass-by-value function args... okay!
- Check for dangerous or inefficient QByteArray usage... okay!
- Check for invalid SIGNALs and SLOTs passed to connect()... okay!
- Check for Qt methods that should be avoided... okay!
- Check for QMIN and QMAX macros... okay!
- Check for classes that should use the 'Q_OBJECT' macro... okay!
- Check for signals: and slots:... okay!
- Check for spelling errors... okay!
- Check for system calls to replace by KDE or Qt equivalents... okay!