Home >  Krazy Code Checker >  KDESUPPORT >  kdesupport >  eigen

Other kdesupport/eigen reports: [APIDOX] [Docs]

Results for kdesupport/kdesupport/eigen

Checkers Run = 26
Files Processed = 16
Total Issues = 20 ...as of July 05 2008 06:08:12 (SVN revision 828235)

• For File Type c++
  1. Check for TRUE and FALSE macros... okay!
  2. Check for methods that return 'const' refs in public classes... okay!
  3. Check for contractions in strings... okay!
  4. Check for an acceptable copyright... okay!
  5. Check for cpp macros and usage... OOPS! 2 issues found!
     • src/util.h: O/S or Compiler specific macro line#39[__GNUC__],40[__GNUC__>=4] (2)

     C++ source files and non-installed headers should NOT use cpp conditionals that check for a certain O/S or compiler; instead use CMake HAVE_foo macros. We want to check for features discovered during CMake time rather than for a specific O/S.

  6. Check single-char QString operations for efficiency... okay!
  7. Check public classes with private members or d-pointer issues... okay!
  8. Check for QString compares to ""... okay!
  9. Check that file ends with a newline... okay!
  10. Check for C++ ctors that should be declared 'explicit'... okay!
  11. Check validity of i18n calls... okay!
  12. Check for invalid icon names... okay!
  13. Check for proper include directives... OOPS! 2 issues found!
      • src/projective.h: missing or improper include guard in header
      • examples/qt/camera.cpp: include own header first line#29

      Use <..> to include installed headers; <QtModule/QClass> to include Qt headers from installed headers; cpp file should include their own headers first; other rules apply, see http://techbase.kde.org/Policies/Library_Code_Policy#Getting_.23in cludes_right. Use include guards in headers with appropriatedly encoded macro names.

  14. Check for inline methods in public classes... okay!
  15. Check for an acceptable license... OOPS! 16 issues found!
      • src/projective.h: unacceptable license (GPL (v2+)) for library code
      • src/ludecomposition.h: unacceptable license (GPL (v2+)) for library code
      • src/regressioninternal.h: unacceptable license (GPL (v2+)) for library code
      • src/util.h: unacceptable license (GPL (v2+)) for library code
      • src/vectorbase.h: unacceptable license (GPL (v2+)) for library code
      • src/matrixbase.h: unacceptable license (GPL (v2+)) for library code
      • src/linearsolverbase.h: unacceptable license (GPL (v2+)) for library code
      • src/regression.h: unacceptable license (GPL (v2+)) for library code
      • src/vector.h: unacceptable license (GPL (v2+)) for library code
      • src/matrix.h: unacceptable license (GPL (v2+)) for library code
      • src/linearsolver.h: unacceptable license (GPL (v2+)) for library code
      • src/ludecompositionbase.h: unacceptable license (GPL (v2+)) for library code
      • src/disabled/quaternion.cpp: missing license
      • src/disabled/quaternion.h: unacceptable license (GPL (v2+)) for library code
      • examples/qt/camera.cpp: unacceptable license (GPL (v2+)) for library code
      • examples/qt/camera.h: unacceptable license (GPL (v2+)) for library code

      Each source file must contain a license or a reference to a license which states under which terms the software may be used, modified and redistributed. For details regarding KDE's licensing policy please visit http://techbase.kde.org/Policies/Licensing_Policy.

  16. Check for assignments to QString::null... okay!
  17. Check for compares to QString::null... okay!
  18. Check for inappropriate pass-by-value function args... okay!
  19. Check for dangerous or inefficient QByteArray usage... okay!
  20. Check for invalid SIGNALs and SLOTs passed to connect()... okay!
  21. Check for Qt methods that should be avoided... okay!
  22. Check for QMIN and QMAX macros... okay!
  23. Check for classes that should use the 'Q_OBJECT' macro... okay!
  24. Check for signals: and slots:... okay!
  25. Check for spelling errors... okay!
  26. Check for system calls to replace by KDE or Qt equivalents... okay!