Home >  Krazy Code Checker >  kde-4.x >  kdeutils >  kfloppy

krazy2 Analysis

Checkers Run = 36
Files Processed = 9
Total Issues = 14 ...as of March 13 2010 04:15:50 CET

• For File Type desktop
  1. Check that file ends with a newline [endswithnewline]...okay!
  2. Check for invalid icon names [iconnames]...okay!
  3. Check for spelling errors [spelling]...okay!
  4. Validates desktop files using 'desktop-file-validate' [validate]...okay!
• For File Type messages
  1. Check for appending to rc.cpp [rcappend]...okay!
• For File Type c++
  1. Check for TRUE and FALSE macros [captruefalse]...okay!
  2. Check for methods that return 'const' refs in public classes [constref]...okay!
  3. Check for an acceptable copyright [copyright]...okay!
  4. Check for cpp macros and usage [cpp]...OOPS! 2 issues found!
     • debug.h: O/S or Compiler specific macro line# 54,57 (2)

     C++ source files and non-installed headers should NOT use cpp conditionals that check for a certain O/S or compiler; instead use CMake HAVE_foo macros. We want to check for features discovered during CMake time rather than for a specific O/S.

  5. Check for code that should be considered crashy. [crashy]...okay!
  6. Check single-char QString operations for efficiency [doublequote_chars]...okay!
  7. Check public classes with private members or d-pointer issues [dpointer]...okay!
  8. Check for QString compares to "" [emptystrcompare]...okay!
  9. Check that file ends with a newline [endswithnewline]...okay!
  10. Check for C++ ctors that should be declared 'explicit' [explicit]...okay!
  11. Check for foreach loop issues [foreach]...okay!
  12. Check validity of i18n calls [i18ncheckarg]...okay!
  13. Check for invalid icon names [iconnames]...okay!
  14. Check for proper include directives [includes]...okay!
  15. Check for inline methods in public classes [inline]...okay!
  16. Check for an acceptable license [license]...okay!
  17. Check for assignments to QString::null [nullstrassign]...OOPS! 7 issues found!
      • format.cpp: line# 36,383,551,622,743,801,899 (7)

      Do not assign QString::null or QString() to a QString. Instead use the .clear() method. For example, "str = QString::null" becomes "str.clear()". When returning an empty string from a method use "return QString()" When passing an empty string use "QString()".

  18. Check for compares to QString::null or QString() [nullstrcompare]...okay!
  19. Check for C++ operators that should be 'const' [operators]...okay!
  20. Check for inappropriate pass-by-value function args [passbyvalue]...okay!
  21. Check for postfix usage of ++ and -- [postfixop]...okay!
  22. Check for dangerous or inefficient QByteArray usage [qbytearray]...okay!
  23. Check for Qt classes that should not be used [qclasses]...OOPS! 1 issues found!
      • floppy.h: QLineEdit[KLineEdit],QComboBox[KComboBox],QComboBox[KComboBox],QComboBox[KComboBox]

      Don't use Qt 4 classes that are deprecated. Additionally make sure to use the KDE version of some Qt GUI elements to provide a consistent look and feel for the KDE desktop. The KDE classes are not just adding functionalities to the Qt base class and are mostly not even based on the Qt class. http://techbase.kde.org/Policies/API_to_Avoid Please refer to the API documentation for details before porting to the K classes.

  24. Check for Qt methods that should be avoided [qmethods]...okay!
  25. Check for QMIN and QMAX macros [qminmax]...okay!
  26. Check for classes that should use the 'Q_OBJECT' macro [qobject]...okay!
  27. Check for signals: and slots: [sigsandslots]...okay!
  28. Check for spelling errors [spelling]...okay!
  29. Check for strings used improperly or should be i18n. [strings]...OOPS! 4 issues found!
      • floppy.cpp: QLatin1String issues line# 436,438,510 (3)
      • format.cpp: QLatin1String issues line# 502 (1)

      Some QString methods (like startsWith() and endsWith()) are more efficient if they are passed a QLatin1String, avoiding an implicit conversion from const char *.

  30. Check for system calls to replace by KDE or Qt equivalents [syscalls]...okay!
  31. Check for typedefs that should be replaced by Qt typedefs [typedefs]...okay!